Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip local event check #732

Merged
merged 2 commits into from Feb 24, 2017
Merged

Conversation

herrmannplatz
Copy link
Contributor

@herrmannplatz herrmannplatz commented Feb 6, 2017

No need to look up every message we decrypt. Proteus.errors.DecryptError.DuplicateMessage errors are handled and ignored anyway


future_sessions = []
@logger.info "Fetched pre-keys for '#{Object.keys(user_pre_key_map).length}' users.", user_pre_key_map
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really want to make this an info message? Info loggings are quite verbose.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w00t. it was you who added this logging

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops! 🙄

@herrmannplatz herrmannplatz force-pushed the improvement/skip-local-event-check branch from 34982aa to 251c0e2 Compare February 24, 2017 09:30
@herrmannplatz herrmannplatz merged commit c26fb38 into dev Feb 24, 2017
@herrmannplatz herrmannplatz deleted the improvement/skip-local-event-check branch February 24, 2017 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants