Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change WT_SESSION.verify to not error on leaked blocks, by default. #2016

Merged
merged 3 commits into from
Jun 8, 2015

Conversation

keithbostic
Copy link
Contributor

Reference WT-1959.

false, don't error if we leak blocks unless strict is configured.

Reference WT-1959.
@keithbostic keithbostic self-assigned this Jun 6, 2015
@michaelcahill
Copy link
Contributor

This needs a note in the upgrading section of the docs. Otherwise, lgtm. Thanks!

@keithbostic
Copy link
Contributor Author

Here's what I added to the upgrading docs:

The WT_SESSION.verify method in this release has a new configuration option,
\c strict. By default, with \c strict set to \c false, WT_SESSION.verify will no longer 
return an error for problems that do not impact the future use of the object (for
example, if a leaked block were detected, the application can continue to run). 
WT_SESSION.verify will continue to output an error message whenever an error
is detected, only the final return value is affected.  This change allows
applications to verify objects and continue if at all possible. Applications in
development should configure \c strict to \c true in order to terminate the
application whenever an error is detected.

Once the build tests are done, I'll merge the change.

keithbostic added a commit that referenced this pull request Jun 8, 2015
Change WT_SESSION.verify to not error on leaked blocks, by default.
@keithbostic keithbostic merged commit 6310c3f into develop Jun 8, 2015
@keithbostic keithbostic deleted the verify-block-leak branch June 8, 2015 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants