WT-2691 Use wrappers for ctype functions to avoid sign extension errors #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rors. Create __wt_* versions of all ctype functions, and use them whenever wt_internal.h is available. Add check to prevent direct use of ctype functions from core source.
|
@keithbostic, can you review please? |
ddanderson
changed the title
| __wt_iscntrl(int c) | ||
| { | ||
| return iscntrl((unsigned char)c); | ||
| } |
There was a problem hiding this comment.
Consider omitting unused wrapper until we need them.
Remove unused wrappers.
|
@michaelcahill, thanks for the comments, please merge if this resolves them. |
| @@ -599,7 +600,7 @@ config_opt_file(CONFIG *cfg, const char *filename) | |||
| rtrim = comment; | |||
|
|
|||
| /* Skip trailing space again. */ | |||
| while (rtrim > ltrim && isspace(rtrim[-1])) | |||
| while (rtrim > ltrim && isspace((unsigned char)rtrim[-1])) | |||
There was a problem hiding this comment.
@ddanderson, I'd suggest using u_char.
|
@ddanderson, lgtm, merge at will as far as I'm concerned. |
|
self reviewing this last bit, and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create _wt* versions of all ctype functions, and use them whenever wt_internal.h is available. Add check to prevent direct use of type functions from core source.
This is an alternative to simply banning the use of plain 'char', as in #2783.