Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WT-7864 Add support to run.py for running lists/ranges of scenarios in a test #6812

Merged
merged 4 commits into from
Jul 21, 2021

Conversation

sauclovian-wt
Copy link
Contributor

Add support to run.py for running lists/ranges of scenarios with -s.

The syntax supported matches e.g. 1-3,5,7-9. A single number is handled
as a trivial list.

The syntax supported matches e.g. 1-3,5,7-9. A single number is handled
as a trivial list.
@lukech
Copy link
Contributor

lukech commented Jul 17, 2021

autobuild: Can one of the admins verify this patch?

@luke-pearson luke-pearson self-requested a review July 19, 2021 01:08
@luke-pearson
Copy link
Contributor

Thanks for submitting this improvement, I'll review it today. 👍

@@ -178,16 +178,38 @@ def show_env(verbose, envvar):
# e.g. test_util03 -> util
reCatname = re.compile(r"test_([^0-9]+)[0-9]*")

# look for a list of the form 0-9,11,15-17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize the start of comments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Sorry, going to take a while to get used to that...

@luke-pearson
Copy link
Contributor

Please update the usage text on line 134.

@luke-pearson luke-pearson self-assigned this Jul 19, 2021
@sauclovian-wt
Copy link
Contributor Author

Updated the usage message too, good point :-)

# Look for a list of the form 0-9,11,15-17.
def parse_int_list(str):
ret = {}
# divide into ranges separated by commas
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sauclovian-wt all comments should be fully formed sentences.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I fixed the rest of them. Sorry, this is probably going to continue to happen some in the short term as I'm not used to that requirement :-/

@luke-pearson
Copy link
Contributor

@sauclovian-wt This is looking good to me, one final comment regarding adding an additional comment 👍 .

Copy link
Contributor

@luke-pearson luke-pearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@sueloverso sueloverso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sueloverso sueloverso merged commit 29a290b into wiredtiger:develop Jul 21, 2021
@sauclovian-wt
Copy link
Contributor Author

Thanks!

@sauclovian-wt sauclovian-wt deleted the WT-7864-scenario-lists branch July 21, 2021 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants