Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect StopAction in V1 Filter #2335

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Respect StopAction in V1 Filter #2335

merged 1 commit into from
Aug 30, 2023

Conversation

Mahoney
Copy link
Collaborator

@Mahoney Mahoney commented Aug 29, 2023

We should only continue to V2 filters if the V1 filters return a ContinueAction.

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

We should only continue to V2 filters if the V1 filters return a ContinueAction.
@Mahoney Mahoney requested a review from a team as a code owner August 29, 2023 16:10
@Mahoney Mahoney merged commit e4ad24a into master Aug 30, 2023
7 checks passed
@Mahoney Mahoney deleted the fix-filters branch August 30, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant