Allow empty URI path segments after the first #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[RFC 3986](https://datatracker.ietf.org/doc/html/rfc3986#section-3.3) disallows an empty segment for the _first_ segment of the path, but permits it in any remaining segments. Jetty 9+ is stricter by default, disallowing _all_ empty segments. We can revert to the older behaviour, allowing more general mocking, by setting Jetty's UriCompliance to UNSAFE.
Mahoney
force-pushed
the
allow-empty-segments
branch
from
258748e
to
c14d29f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 3986 disallows an empty segment for the first segment of the path, but permits it in any remaining segments.
Jetty 9+ is stricter by default, disallowing all empty segments.
We can revert to the older behaviour, allowing more general mocking, by setting Jetty's
UriCompliancetoUNSAFE.Submitter checklist
#help-contributingor a project-specific channel like#wiremock-java