Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BEFORE_RESPONSE_SENT request phase to the stub-mapping schema #2428

Merged

Conversation

picimako
Copy link
Contributor

@picimako picimako commented Oct 9, 2023

I added the BEFORE_RESPONSE_SENT enum value to the stub-mapping schema as a possible serveEventListener request phase.

The related PR that added support for this was merged back in August, so it was missing from the schema.

References

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • Recommended: If you participate in Hacktoberfest 2023, maake sure you're signed up there and in the WireMock form
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@picimako picimako requested a review from a team as a code owner October 9, 2023 15:54
@tomakehurst tomakehurst merged commit c66237f into wiremock:master Oct 9, 2023
7 checks passed
@picimako picimako deleted the before-response-sent-request-phase branch October 9, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants