Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: split getLines method of Diff class #2460

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Refactor: split getLines method of Diff class #2460

merged 3 commits into from
Nov 3, 2023

Conversation

julianahrens1999
Copy link
Contributor

We tried fixing issue #2047. To accomplish this, we first set out to refactor the Diff class. We extracted methods for better readability. Unfortunately we did not manage to fix the issue.

References

Issue #2047

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • Recommended: If you participate in Hacktoberfest 2023, make sure you're signed up there and in the WireMock form
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@julianahrens1999 julianahrens1999 requested a review from a team as a code owner October 24, 2023 13:56
@tomakehurst
Copy link
Member

Could we get a ./gradlew spotlessApply please?

@tomakehurst tomakehurst merged commit fb4bc98 into wiremock:master Nov 3, 2023
@tomakehurst
Copy link
Member

Thanks!

henrik242 pushed a commit to henrik242/wiremock that referenced this pull request Nov 10, 2023
@julianahrens1999 @PhilippSchueler5648
@DennisPietruck0001 @henrik242
Refactor: split getLines method of Diff class (wiremock#2460)
ba68964 
* Refactoring Diff into its sections

* Show Sections according to whether they have a spacer or not

---------

Co-authored-by: pschuele <philipp.schueler@otto.de>
Co-authored-by: Dennis Pietruck <85478202+DennisPietruck0001@users.noreply.github.com>
Marvin9 pushed a commit to Marvin9/wiremock that referenced this pull request Nov 20, 2023
@julianahrens1999 @PhilippSchueler5648
@DennisPietruck0001 @Marvin9
Refactor: split getLines method of Diff class (wiremock#2460)
fd0fa59 
* Refactoring Diff into its sections

* Show Sections according to whether they have a spacer or not

---------

Co-authored-by: pschuele <philipp.schueler@otto.de>
Co-authored-by: Dennis Pietruck <85478202+DennisPietruck0001@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@julianahrens1999 @tomakehurst @oleg-nenashev @PhilippSchueler5648 @DennisPietruck0001