Delegate parsing of media types to library #2471
Conversation
|
|
||
| private String[] parts; | ||
| private final Optional<MediaType> maybeMediaType; |
There was a problem hiding this comment.
This has an IDE warning, but I believe it's the right thing to do to give us the ability to more easily handle the absense of the value. Thoughts? (I've not done Java in ~18 months so my knowledge is rusty!)
Instead of us handling any media-type related parsing, we should instead delegate to a library for this. This also shades the media-type library into the built JAR.
jamietanna
force-pushed
the
feature/media-type-library
branch
from
0ec3389
to
51911ed
Compare
|
Thanks Oleg, I think I've done the shading right, but let me know! |
|
Sorry @jamietanna in its current state I feel like the library isn't offloading enough of the work to be worth the addition of an extra dependency. I agree in general that it would be good to outsource generic HTTP wrangling to libraries. Ideally I'd like to have a whole HTTP model (including a better URL implementation than Java's) extracted as a library, but that's a different sized job entirely... |
|
Hey @tomakehurst that's fair. Happy to leave this open, or close and we can look at adding in the future. I know that one thing I was considering as a useful extension would be to allow Wiremock to perform content-negotiation - I've built some APIs in the past that will have an That being said, I'm not sure if it'd be that well-used - I don't see an issue raised for it, so happy to raise one and see if it's something the community would want? |
|
I've had similar thoughts about content negotiation in the past but as you've said, there doesn't seem to be much demand for it. I'll close this for now (in a futile effort at keeping things tidy), but happy to re-open it if we want to expand this use case a bit in the future. |
Instead of us handling any media-type related parsing, we should instead
delegate to a library for this.
This is a reimplementation of #1686 in part to freshly recreate it to avoid the merge conflicts, but also shamelessly to see if it can count for Hacktoberfest 馃巸