Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handlebars math helper handles large negative integers #2706

Merged
merged 1 commit into from
May 7, 2024

Conversation

RafeArnold
Copy link
Contributor

Currently, when the result of the handlebars math helper is a negative number less than java.lang.Integer.MIN_VALUE, it's incorrectly coerced into a java.lang.Integer. This PR fixes that.

References

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@RafeArnold RafeArnold requested a review from a team as a code owner May 4, 2024 09:11
@dieppa dieppa self-assigned this May 7, 2024
Copy link
Contributor

@dieppa dieppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dieppa dieppa merged commit e8c78fa into master May 7, 2024
9 checks passed
@dieppa dieppa deleted the fix-handlebars-math-helper branch May 7, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants