Make keyboard lock players based on its own synchronous value.

[thegrb93]

Fix #1024

[immibis]

That was quick. I was going to do it myself tomorrow.

The other part of #1024 was to make it true by default.

(and the other other part of #1024 was to evaluate whether it's ever useful to have it false)

[Divran]

Gotta love how easy it is to change these things with the wire tool object. I believe it was Nebual who made most of that functionality? Great job Nebual.

[thegrb93]

It is true by default I think? And yes there are cases where you may want to move while typing.

[immibis]

Yes, it is true by default. I must've set it to false a long time ago (maybe to find out what it did).

[TomyLobo]

This was done back then in order to not lock people in who have no idea what a wire keyboard is.
I'm not quite up-to-date: Is there a key to leave and is that displayed prominently throughout the entire time you're in the keyboard?

[suunr]

yes, it shows "alt to leave" at the bottom of the screen

[TomyLobo]

All the time?

[suunr]

yup

[TomyLobo]

Good, then I'm fine with making this a per-keyboard setting.

[TomyLobo]

Does it make sense to make this an input?

[immibis]

@TomyLobo I can't think of a use case, but I also don't see a reason why it wouldn't make sense. (Besides metagaming, which is fairly weak)

[Divran]

all of cam controller's options are ui checkboxes, but they could all be
inputs as well. I dunno, but I guess it makes slightly more sense for it to
be a checkbox

On Mon, Nov 30, 2015 at 9:58 AM, immibis notifications@github.com wrote:

@TomyLobo https://github.com/TomyLobo I can't think of a use case, but
I also don't see a reason why it wouldn't make sense. (Besides metagaming,
which is fairly weak)

—
Reply to this email directly or view it on GitHub
#1025 (comment).

[AbigailBuccaneer]

There's no real reason you'd ever want to change this via an input.

Maybe if people reallly want to change it, then it should be a DataTables var (so that it shows up in the 'C › right click › Properties' or whatever menu) and then there should be a generic entity that can change DataTables of other entities. That way we avoid bloating code with inputs for every imaginable configuration setting you might hypothetically want to change, and we add the ability to change every configuration setting (that uses DataTables, which is admittedly not many but it should be) with one entity.

[TomyLobo]

maybe you want to switch between modes of a larger contraption.
I dont quite remember, did non-synchronous mode let WASD through?

[Divran]

synchronous lets nothing through, non synchronous lets everything through

[TomyLobo]

ok so then you have your use case: switching between advpod-based ship controls and whatever you do with a wire keyboard

[Divran]

but
both of those use cases are be done using synchronous (edit: adv-pod based controls can be done using either sync or non sync, if you're sitting in a chair, since the chair is gonna block your input anyway)

[TomyLobo]

I don't quite understand.
the chair blocks wire_keyboard?

[Divran]

no, if you sit in a chair, your key presses will not cause you to move or interact with anything in the game, except E to exit. It blocks your input

[TomyLobo]

But they will still trigger advpod.
Unless you're also using a synchronous wire keyboard, i guess?

[Divran]

I don't know what happens to adv pod if you're also using a synchronous keyboard. I've never tried it

[Divran]

I don't see why this hasn't been merged already. I'll merge it tonight if no one complains