feat: Recalculate dimensions if reported as A1:A1

wireservice · Nov 7, 2023 · d4bd195 · d4bd195
1 parent 9bcf2a1
commit d4bd195
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -1,3 +1,8 @@
+0.4.0 - November 7, 2023
+------------------------
+
+* The ``reset_dimensions`` argument to :meth:`.Table.from_xlsx` defaults to ``None`` instead of ``False``. If ``reset_dimensions`` is ``None``, and if the worksheet's dimensions are ``A1:A1``, recalculate the worksheet's dimensions. To disable this behavior, set ``reset_dimensions`` to ``False``.
+
 0.3.0 - October 30, 2023
 ------------------------
 

diff --git a/agateexcel/table_xlsx.py b/agateexcel/table_xlsx.py
@@ -12,7 +12,7 @@
 
 
 def from_xlsx(cls, path, sheet=None, skip_lines=0, header=True, read_only=True,
-              reset_dimensions=False, row_limit=None, **kwargs):
+              reset_dimensions=None, row_limit=None, **kwargs):
     """
     Parse an XLSX file.
 
@@ -72,7 +72,7 @@ def from_xlsx(cls, path, sheet=None, skip_lines=0, header=True, read_only=True,
         offset = 0
         rows = []
 
-        if read_only and reset_dimensions:
+        if read_only and (reset_dimensions or reset_dimensions is None and sheet.calculate_dimension() == 'A1:A1'):
             sheet.reset_dimensions()
             sheet.calculate_dimension(force=True)
 

diff --git a/docs/conf.py b/docs/conf.py
@@ -12,7 +12,7 @@
 
 project = 'agate-excel'
 copyright = '2017, Christopher Groskopf'
-version = '0.3.0'
+version = '0.4.0'
 release = version
 
 # -- General configuration ---------------------------------------------------

diff --git a/setup.py b/setup.py
@@ -5,7 +5,7 @@
 
 setup(
     name='agate-excel',
-    version='0.3.0',
+    version='0.4.0',
     description='agate-excel adds read support for Excel files (xls and xlsx) to agate.',
     long_description=long_description,
     long_description_content_type='text/x-rst',