Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodetect column types using the Excel file's cell types #36

Merged
merged 1 commit into from
Dec 1, 2019

Conversation

lcorbasson
Copy link
Contributor

The rationale behind this commit is that if typing information is available in the Excel file, we should probably use it.

This is especially useful for Excel files with cells defined as text while seemingly containing numbers (phone numbers, numbers like "3,6" where one can't be sure of whether the comma is a decimal separator or not, etc.), which are currently distorted when imported.

@jpmckinney jpmckinney merged commit 1b13edb into wireservice:master Dec 1, 2019
@jpmckinney
Copy link
Member

Thank you! I've added you to AUTHORS.rst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants