Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add argument to from_sql for SELECT query #14

Closed
jpmckinney opened this issue Jan 31, 2016 · 2 comments
Closed

Add argument to from_sql for SELECT query #14

jpmckinney opened this issue Jan 31, 2016 · 2 comments
Labels
feature priority-normal

Comments

@jpmckinney
Copy link
Member

So that csvsql and sql2csv can use it.
@onyxfish
Copy link
Collaborator

onyxfish commented Feb 5, 2016

So there was a good reason I didn't do this and now I don't remember what it was. Something to do with the way the queries are structured in sqlalchemy was blocking me. But yes, it is essential if we're migrating csvsql to this.

@onyxfish
Copy link
Collaborator

Superseded by from_sql_query though this still turns out to be impractical for csvkit and I've stuck with the existing code there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature priority-normal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpmckinney @onyxfish