Merge pull request #770 from castorf/master

lowercase null_values for data_types.
wireservice · Oct 4, 2023 · c773cb7 · c773cb7
2 parents 66222ec + ac89331
commit c773cb7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/agate/data_types/base.py b/agate/data_types/base.py
@@ -13,7 +13,7 @@ class DataType:  # pragma: no cover
         :code:`None` when encountered by this data type.
     """
     def __init__(self, null_values=DEFAULT_NULL_VALUES):
-        self.null_values = null_values
+        self.null_values = [v.lower() for v in null_values]
 
     def test(self, d):
         """

diff --git a/tests/test_data_types.py b/tests/test_data_types.py
@@ -55,6 +55,10 @@ def test_no_cast_nulls(self):
         casted = tuple(t.cast(v) for v in values)
         self.assertSequenceEqual(casted, ('', 'N/A', None))
 
+    def test_null_values(self):
+        t = Text(null_values=['Bad Value'])
+        self.assertEqual(t.cast('Bad Value'), None)
+
 
 class TestBoolean(unittest.TestCase):
     def setUp(self):