Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modification to developer install steps #702

Closed
dbfreem opened this issue Nov 28, 2017 · 1 comment
Closed

modification to developer install steps #702

dbfreem opened this issue Nov 28, 2017 · 1 comment

Comments

@dbfreem
Copy link

dbfreem commented Nov 28, 2017

I was trying to follow the developer install steps on the readthedocs site. Two observations

  1. Shouldn't the steps tell the user to activate their virtualenv before running python setup.py develop. Like a source bin/activate or bin/activate

  2. Not sure if this one matters or not but noticed the repo that it says to clone is at onyxfish/agate and not wireservice/agate

I can submit a PR for these if you like but wanted to put in an issue first.

@jpmckinney
Copy link
Member

When using mkvirtualenv from virtualenvwrapper, the venv is automatically activated. That said, we'd accept a PR that used the plain virtualenv package instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants