Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] A connector with no wires connected is not handled correctly #217

Closed
kvid opened this issue Feb 12, 2021 · 0 comments
Closed

[bug] A connector with no wires connected is not handled correctly #217

kvid opened this issue Feb 12, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@kvid
Copy link
Collaborator

kvid commented Feb 12, 2021 •
edited

  1. The graphviz.backend raises an exception when processing a harness including a connector with neither pinlabels, nor pincolors, and no wires connected. This is clearly a bug. See also variations of this bug below.
connectors:
  Simple:
    pincount: 2
  1. A connector in the harness with pinlabels or pincolors, but without any wires connected is rendered with all pin numbers hidden. I cannot see the rationale behind this. There are use cases where unconnected connectors make sense, e.g. documenting mating connectors, or when documenting connector pinout of one or more connectors is the sole purpose.
connectors:
  HiddenPins:
    pinlabels: [+5V, GND]
  1. An exception is raised when processing a harness including a connector with pinlabels or pincolors, and internal loops, but no ordinary wires connected. This is also clearly a bug. Documenting a loop-back connector is then impossible, but can be useful in similar use cases as above.
connectors:
  Loopback:
    pinlabels: [IN, OUT]
    loops:
      - [1, 2]
kvid added a commit to kvid/WireViz that referenced this issue Feb 12, 2021
@kvid
Show connector pins even when all are unconnected
7ccbc46 
Bug: Hiding connector pins when none are connected is not reasonable.
When combined with loops or neither pinlabels nor pincolors, then
exceptions are raised as well.

Fix: Forcing pins at the left side in such cases solves wireviz#217.
@kvid kvid mentioned this issue Feb 12, 2021
Merged
formatc1702 pushed a commit that referenced this issue Mar 20, 2021
@kvid @formatc1702
Show connector pins even when all are unconnected
7546991 
Bug: Hiding connector pins when none are connected is not reasonable.
When combined with loops or neither pinlabels nor pincolors, then
exceptions are raised as well.

Fix: Forcing pins at the left side in such cases solves #217.
@kvid kvid closed this as completed Mar 27, 2021
@kvid kvid added the bug Something isn't working label Aug 18, 2023
@kvid kvid mentioned this issue Dec 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kvid