Avoid Graphviz error when hiding all pins #375

kvid · 2024-06-05T16:31:11Z

This bug was reported in #257 more than 2.5 years ago, but is still present in v0.4, and can be triggered by e.g. this YAML input:

connectors:
  X1:
    pincount: 2
    hide_disconnected_pins: true
connections:
 - - X1

Graphviz reports an error when the HTML table of pins is empty.

This minor change should fix #257

Fixes #257

src/wireviz/Harness.py

Fixes #257

This was referenced Jun 5, 2024

Collect changes for v0.4.1-rc #365

Draft

[bug] hide_disconnected_pins when nothing is connected #257

Open

kvid force-pushed the release/v0.4.1-rc branch from 8188ddd to b32ce91 Compare June 7, 2024 22:48

Avoid Graphviz error when hiding all pins (#375)

20cfaef

Fixes #257

kvid force-pushed the release/v0.4.1-rc branch from db1e77f to ddb2cba Compare June 7, 2024 23:49

kvid force-pushed the fix257 branch from ea1f6ea to 20cfaef Compare June 7, 2024 23:53

kvid force-pushed the release/v0.4.1-rc branch from 661f3cf to 2d38267 Compare June 12, 2024 01:08

kvid requested a review from amotl June 12, 2024 10:00

amotl approved these changes Jun 12, 2024

View reviewed changes

src/wireviz/Harness.py Show resolved Hide resolved

formatc1702 merged commit 2f4fe11 into release/v0.4.1-rc Jun 14, 2024
4 checks passed

formatc1702 deleted the fix257 branch June 14, 2024 13:18

kvid linked an issue Jun 22, 2024 that may be closed by this pull request

[bug] hide_disconnected_pins when nothing is connected #257

Open

kvid added a commit that referenced this pull request Jul 5, 2024

Avoid Graphviz error when hiding all pins (#375)

6488eb5

Fixes #257

Provide feedback