Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the block view #19

Closed
AlexITC opened this issue Jun 9, 2018 · 1 comment
Closed

Improve the block view #19

AlexITC opened this issue Jun 9, 2018 · 1 comment
Labels
roadmap A feature that will be developed server Changes required on the server project web-ui Changes required on the web-ui project

Comments

@AlexITC
Copy link
Collaborator

AlexITC commented Jun 9, 2018

The block view could be improved.

Expected behavior

The block view displays a summary, and a paginated list with a summary for each transaction, the list is sorted from newest to oldest, it displays 10 items by default, example:
expected-address-view

Actual behavior

The block view displays the list of all the transactions which doesn't help too much because there are no details for the transactions:
block-view

Steps to reproduce the behavior

Go to https://xsnexplorer.io/blocks/95833f1e6a3475a0bf2478865e23a4e731d2f5ccf82883ee9a3d9a9668ee4e24

@AlexITC AlexITC added enhancement web-ui Changes required on the web-ui project server Changes required on the server project labels Jun 9, 2018
@AlexITC
Copy link
Collaborator Author

AlexITC commented Jul 8, 2018

The endpoint to call should be GET /blocks/:hash/transactions.

This is an example call:

➜  server git:(develop) ✗ http GET localhost:9000/blocks/000004645e2717b556682e3c642a4c6e473bf25c653ff8e8c114a3006040ffb8/transactions limit==3 orderBy==received:desc
HTTP/1.1 200 OK

{
    "data": [
        {
            "blockhash": "59e80af3e04c597161e02fb2910c29b2fcc7bc4d8ece56583c9abc15616a36f8", 
            "id": "7ea61a229b598ae45b618d3a148760887e70d65000dfc73b49cf96d91825a918", 
            "received": 15000, 
            "sent": 0, 
            "size": 519, 
            "time": 1522809775
        }, 
        {
            "blockhash": "7a1e7c4be6b0b885e87935a24b250d6606444d42262b0eceedeedf64ed6434d7", 
            "id": "f33a48f3e1c2cb6f760d32d7db09ef077e4db1d47543abe2eb90ed33474887fc", 
            "received": 42.75, 
            "sent": 22.5, 
            "size": 234, 
            "time": 1526174028
        }, 
        {
            "blockhash": "244987e5695f50c078ff9ddcf30dd3c2ba7ff6d7810ec8a610216b72131291f0", 
            "id": "1be1c4748cf238233a92f9871574bad3023fad69cb77fba2477e2a8a849f9ce7", 
            "received": 22.5, 
            "sent": 0, 
            "size": 234, 
            "time": 1523090311
        }
    ], 
    "limit": 3, 
    "offset": 0, 
    "total": 88
}

mario128mex added a commit to mario128mex/block-explorer that referenced this issue Jul 17, 2018
transactions for the block are now retrieved separately, the
transactions table is paginated and shows more info and
finally the view now is mobile friendly
mario128mex added a commit to mario128mex/block-explorer that referenced this issue Jul 19, 2018
transactions for the block are now retrieved separately, the
transactions table is paginated and shows more info and
finally the view now is mobile friendly
mario128mex added a commit to mario128mex/block-explorer that referenced this issue Jul 20, 2018
transactions for the block are now retrieved separately, the
transactions table is paginated and shows more info and
finally the view now is mobile friendly
mario128mex added a commit to mario128mex/block-explorer that referenced this issue Jul 23, 2018
transactions for the block are now retrieved separately, the
transactions table is paginated and shows more info and
finally the view now is mobile friendly
mario128mex added a commit to mario128mex/block-explorer that referenced this issue Jul 23, 2018
transactions for the block are now retrieved separately, the
transactions table is paginated and shows more info and
finally the view now is mobile friendly
mario128mex added a commit to mario128mex/block-explorer that referenced this issue Jul 23, 2018
transactions for the block are now retrieved separately, the
transactions table is paginated and shows more info and
finally the view now is mobile friendly
@AlexITC AlexITC added the roadmap A feature that will be developed label Aug 8, 2018
AlexITC pushed a commit that referenced this issue Sep 30, 2018
transactions for the block are now retrieved separately, the
transactions table is paginated and shows more info and
finally the view now is mobile friendly
AlexITC added a commit that referenced this issue Oct 1, 2018
- A message is displayed when the transaction list is not available.
- The transaction list is loaded after the block data.
- When the paginated transactions aren't available, the transaction
  list from the block data is displayed.
@AlexITC AlexITC closed this as completed Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap A feature that will be developed server Changes required on the server project web-ui Changes required on the web-ui project
Projects
None yet
Development

No branches or pull requests

1 participant