New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Akka by a Thread Pool / Executor service #398

Closed

cescoffier opened this issue Dec 28, 2014 · 6 comments

Assignees

Labels

Milestone

Member

cescoffier commented Dec 28, 2014

Initially I decided to use Akka for its actor model. But after some time I realize I'm using it as a pure thread pool. It's a big big for a thread pool (as it requires Scala).

We should replace it by a better thread pool service, maybe using Quartz (http://quartz-scheduler.org/generated/2.2.1/html/qs-all/#page/Quartz_Scheduler_Documentation_Set%2Fco-abt_quartz_features.html%23) or pure Executors.

cescoffier added the enhancement label

cescoffier added this to the 0.7.1 milestone

Member Author

cescoffier commented Dec 28, 2014

Except if you use the Akka service directly, you should not be impacted by this change. The current Akka support is going to be exported as an extension.

Contributor

remi-parain commented Jan 11, 2015

I use the akka service when i need the scheduled behavior for a non-harcoded time interval ( no annotation ). Will it be possible to do this with Thread Pool or will it need the extension?

Member Author

cescoffier commented Jan 11, 2015

The service will be a bit different, but you will have this feature, in a more flexible way actually.

If you rely on Akka API, you would need to deploy the (current) Akka-System explicitly.

cescoffier added a commit that referenced this issue


          #398 - Initial implementation of the thread pool service

6e0c6fd

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>

Member Author

cescoffier commented Jan 17, 2015

Ongoing work on the #398 branch.

cescoffier added a commit that referenced this issue


          #398 - support scheduled task

602f2bd

Refactoring
Support of scheduled and periodic tasks
More tests

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>

cescoffier added a commit that referenced this issue


          #398 - HTTP Context migrator

2b62b63

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>

cescoffier added a commit that referenced this issue


          #398 - Fix the system executor and scheduler names

3aea165

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>

cescoffier added a commit that referenced this issue


          #398 - add pool creator

4a921b6

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>

cescoffier added a commit that referenced this issue


          #398 - Integrate the new thread management system

8fd890b

Add the wisdom-thread-pools project to the base distribution
Migrate the router to the new services
Migrate Vertx to the new services

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>

cescoffier added a commit that referenced this issue


          #398 - Add missing license headers

089038f

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>

cescoffier added a commit that referenced this issue


          #398 - Migrate the @AynC support to the new Thread Pool Service

4b1d10a

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>

cescoffier added a commit that referenced this issue


          #398 - Migrate @every support

ecf3175

Also provide a TCCL Execution environment

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>

cescoffier added a commit that referenced this issue


          #398 - Migrate the @every support (scheduler)

bb316fa

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>

cescoffier added a commit that referenced this issue


          #398 - Migrate the monitor dashboard to new Scheduler service

1bc99fc

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>

cescoffier added a commit that referenced this issue


          #398 - Rename the module to wisdom-executors

69266c4

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>

cescoffier added a commit that referenced this issue


          #398 - Add tests about the TCCL migrator

13053e8

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>

Member Author

cescoffier commented Jan 18, 2015

Right now, we still provide Akka (in the 0.7.1), Akka will be moved as an extension in the 0.7.2

cescoffier added a commit that referenced this issue


          #398 - Add documentation

4a507bb

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>

Member Author

cescoffier commented Jan 18, 2015

So, I've made an implementation of executors and schedulers based on the Java Execution Services. This implementation is close to the JavaEE Concurrent specification (so you may recognize some concepts), but is definitely not an implementation (as it's really close to JavaEE).

I've migrated all Wisdom core feature to the new model.

cescoffier closed this as completed

cescoffier self-assigned this

cescoffier mentioned this issue

Executor monitoring from the wisdom monitor #416

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment