Fix notion of module in FileWebJarLib and http://localhost:9000/assets #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rendering. Add source origin in toString of FileWebJarLib. FileWebJarLib will only index file associated with a module (source) when the source jar contain a folder with the same name. This will ease the merge of webjars with a same source (usefull for webcomponent integration). Without this commit, webjar with a same source are deployed and merged but only one webjar is shown in http://localhost:9000/assets
|
Wisdom Framework » wisdom #414 UNSTABLE |
cescoffier
added a commit
that referenced
this pull request
Feb 21, 2015
Fix notion of module in FileWebJarLib and http://localhost:9000/assets
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rendering.
Add source origin in toString of FileWebJarLib.
FileWebJarLib will only index file associated with a module (source)
when the source jar contain a folder with the same name.
This will ease the merge of webjars with a same source (usefull for webcomponent integration).
Without this commit, webjar with a same source are deployed and merged
but only one webjar is shown in http://localhost:9000/assets
You can try with this webcomponent:
https://github.com/cheleb/org.webjars.polymers
mvn clean install them.
add a dependency on:
org.webjars.polymers google-map 0.4.1then go to http://localhost:9000/libs/polymers/0.5.4/google-map/demo.html