Fix notion of module in FileWebJarLib and http://localhost:9000/assets #447

Merged
merged 1 commit into from Feb 21, 2015

Conversation

Projects
None yet
3 participants
@cheleb
Contributor

cheleb commented Feb 20, 2015

rendering.

Add source origin in toString of FileWebJarLib.
FileWebJarLib will only index file associated with a module (source)
when the source jar contain a folder with the same name.

This will ease the merge of webjars with a same source (usefull for webcomponent integration).

Without this commit, webjar with a same source are deployed and merged
but only one webjar is shown in http://localhost:9000/assets

You can try with this webcomponent:
https://github.com/cheleb/org.webjars.polymers

mvn clean install them.

add a dependency on:

org.webjars.polymers google-map 0.4.1

then go to http://localhost:9000/libs/polymers/0.5.4/google-map/demo.html

Fix notion of module in FileWebJarLib and http://localhost:9000/assets
rendering.

Add source origin in toString of FileWebJarLib.
FileWebJarLib will only index file associated with a module (source)
when the source jar contain a folder with the same name.

This will ease the merge of webjars with a same source (usefull for webcomponent integration).

Without this commit, webjar with a same source are deployed and merged
but only one webjar is shown in http://localhost:9000/assets
@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Feb 20, 2015

Wisdom Framework » wisdom #414 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

Wisdom Framework » wisdom #414 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

cescoffier added a commit that referenced this pull request Feb 21, 2015

Merge pull request #447 from cheleb/master
Fix notion of module in FileWebJarLib and http://localhost:9000/assets

@cescoffier cescoffier merged commit 6adfd1b into wisdom-framework:master Feb 21, 2015

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Feb 21, 2015

Member

Thanks !

Member

cescoffier commented Feb 21, 2015

Thanks !

@cescoffier cescoffier added this to the 0.7.1 milestone Feb 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment