refactor spaces and tabs, dump JSON without stringify, add new group_rank for each contest #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dump json without serializing to string for better visibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor spaces and tabs: there were 2-space, 4-space and tab indentations, I refactor them all to 4-space for better readability.
Removed
json.loadsandjson.dumpssodata.jsonwill not have the escape characters for the quotation marks and can be read better if needed.In FetchRanks.py added a new variable group_rank to add user's ranking within the group for this contest in the dictionary entry as the last item. I think displaying a person's in-group ranking fluctuation is perhaps a good indicator to see if one's improving within the group. Can also enable the feature to show "up by x ranks" and "down by x ranks" with red and green arrows when comparing this week's in group ranking with previous week.