Sync uber kraken to wish kraken #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Config example for GCS backend + Mock tests for GCS backend
* Add list options to client interface * Add s3 pagination * Add test for s3 client pagination * Err out pagination on unsupported clients * Eliminate duplicate code * Pack names and continuation token into ListResult * Use variadic functional options for list configuration * Better default * Fix typo
* Refactor s3 backend to use ListObjectsV2Pages * Inline anon func * Better unit test mocks * Remove binary files * Iterate pages until have maxkeys * Review comments * Only capture continuation token from last page * Remove unnecessary token masking out
* Make S3 continuation token nil instead of empty string * Update unit tests
* Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml
+ Support pagination in list and listRespositories handler
+ Fix bug in gcsbackend pagination
+ Response for list with pagination
type ListResponse struct {
Links struct {
Next string `json:"next"`
Self string `json:"self"`
}
Size int `json:"size"`
Result []string `json:"result"`
}
Signed-off-by: peimingming <peimingming@corp.netease.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.