Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/18 search by name #23

Merged
merged 6 commits into from
Jun 16, 2017
Merged

Feature/18 search by name #23

merged 6 commits into from
Jun 16, 2017

Conversation

wovalle
Copy link
Collaborator

@wovalle wovalle commented Jun 10, 2017

I think more work can be done abstracting the ui from the data, but this'll do for this feature.

wistcc
wistcc requested changes Jun 11, 2017
View reviewed changes
Copy link
Owner

@wistcc wistcc left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Minor things but nice to have:

  • The text is not being cleared when the window is hidden.
  • After writing some text, using the numbers to open a project still refer to the first list no to the filtered list.

@wovalle
Copy link
Collaborator Author

wovalle commented Jun 11, 2017

@wistcc Comments addressed

wistcc
wistcc approved these changes Jun 11, 2017
View reviewed changes
Copy link
Owner

@wistcc wistcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👍

@wovalle wovalle merged commit 6de63bc into master Jun 16, 2017
@wistcc wistcc deleted the feature/18-search-by-name branch June 16, 2017 02:38
@wistcc wistcc mentioned this pull request Jun 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wistcc wistcc wistcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wovalle @wistcc