Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify exception text when the channel name is invalid #26

Merged
merged 1 commit into from
Aug 20, 2018

Conversation

acj
Copy link
Member

@acj acj commented Aug 20, 2018

The current message is misleading since the topic may be valid and bear no similarity to the invalid channel name.

@acj acj requested a review from MaxPower15 August 20, 2018 10:23
Copy link
Member

@MaxPower15 MaxPower15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This was probably from forgetting to update it after yyp. 🤦‍♂️

@acj acj force-pushed the acj/clarify-channel-error branch from 61c8121 to 1734883 Compare August 20, 2018 13:27
@acj acj force-pushed the acj/clarify-channel-error branch from 1734883 to 4e260be Compare August 20, 2018 13:45
@acj acj merged commit ee6dbd6 into master Aug 20, 2018
@acj acj deleted the acj/clarify-channel-error branch August 20, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants