Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor compose #37

Merged
merged 5 commits into from Mar 14, 2021
Merged

Refactor compose #37

merged 5 commits into from Mar 14, 2021

Conversation

jechol
Copy link
Member

@jechol jechol commented Oct 21, 2020

This PR fixes following,

  1. Quark.Compose module has duplicated implementation compose([]) and compose_list([]).
  2. compose is defined with def while compose_forward is defined with defpartial.

@jechol jechol mentioned this pull request Oct 21, 2020
Closed
Base automatically changed from master to main March 13, 2021 22:54
expede
expede approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@expede expede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jechol 👋

Oh yeah, this totally makes sense 💯 There was a conflict with a few changes that I just made merging other PRs, so I made those changes directly.

Thanks a bunch for the contribution!

@expede expede merged commit c2fb84b into witchcrafters:main Mar 14, 2021
@jechol jechol deleted the dev/compose branch April 22, 2021 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@expede expede expede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jechol @expede