Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Issue
equal?/2
began usingassert
internally as of640c0fd
.!
)equal?(a, b) or equal?(x, y)
assert
makes this impossibleSteps to Reproduce
On my machine, this does not occur when compiling Witchcraft with fresh deps and
_build
. I was able to reproduce with a new application that used Witchcraft as a dependency. This typically fails onOrd.ex
prop checks.Edited
deps/type_class/lib/type_class/property.ex
, removing theassert
s, and everything works. The offending line requires checking two possible options with anor
. Sinceassert
will blow up on a single failure, this makes any boolean logic impossible.Still Need Better Fail Reporting
While the errors generated by
assert
were more detailed, they were often of little use. For example, this doesn't tell me anything about the values that lead to failure:Better error messages would be very useful. It's not new information that the prop-testing system could be improved, and this should be explored.
History
@SchrodingerZhu reported that Algae was unable to build, failing compile-time prop checks.
Some discussion occurred in that thread. For some reason, I did not receive an email until 5 days later. This isn't the first time this has happened. I will explore my spam filtering and GitHub email settings.