Upgrade analytics

[thomasmarshall]

Should we update the google_analytics_tracking_code method to use the new style tracking code?

slices/app/helpers/pages_helper.rb

Lines 90 to 108 in bd20969

	def google_analytics_tracking_code(*web_property_ids)
	if web_property_ids.first.present? && add_tracking_code?
	analytics_que = "['_setAccount', '#{web_property_ids.shift}'], ['_trackPageview'], ['_trackPageLoadTime']"
	web_property_ids.each_with_index do |web_property_id, index|
	account = (index + 98).chr
	analytics_que << ", ['#{account}._setAccount', '#{web_property_id}'], ['#{account}._trackPageview'], ['#{account}._trackPageLoadTime']"
	end
	javascript_tag <<-JAVASCRIPT
	var _gaq = _gaq || [];
	_gaq.push(#{analytics_que});
	(function() {
	var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
	ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
	var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
	})();
	JAVASCRIPT
	end
	end

[erino]

I was thinking that we should remove the google_analytics_tracking_code method, it's not that hard to copy the code from Google. The add_tracking_code method is the timesaving part.

[thomasmarshall]

Yep, I agree with that.

[bensymonds]

Can we just close this issue, given we have #101? I never really know what the best thing to do is when there's a PR covering an issue. It seems like the issue is now tracked by the PR, so we don't need the issue any more.

[erino]

This is now covered in #101