Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade action versions and default to node 20 #41

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

LeadingMoominExpert
Copy link
Contributor

@LeadingMoominExpert LeadingMoominExpert commented Jan 30, 2024

As stated in the issue here #40, current withastro/action does not work with action/deploy-pages@v4 and upgrading to actions using node 20 is not possible.

This pull request would make v2 release for your action. I tested it with application built with npm and built it using an action published from a fork, and a workflow file like

name: Deploy

on:
  push:
    branches:
    - main
  workflow_dispatch:

permissions:
  contents: read
  pages: write
  id-token: write

jobs:
  build:
    runs-on: ubuntu-latest
    timeout-minutes: 15
    steps:
      - name: Checkout your repository using git
        uses: actions/checkout@v4

      - name: Install, build, and upload your site
        uses: LeadingMoominExpert/withastro-action@v2

  deploy:
    needs: build
    timeout-minutes: 15
    runs-on: ubuntu-latest
    environment:
      name: github-pages
      url: ${{ steps.deployment.outputs.page_url }}

    steps:
      - name: Deploy to GitHub Pages
        id: deployment
        uses: actions/deploy-pages@v4

Note that the example uses actions/deploy-pages@v4, which was not previously possible

Resolves #40

@natemoo-re
Copy link
Member

Thank you! This is on my list to review and merge today.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug 🐛 v1.0.6 not compatible with action/deploy-pages v4 — isn't able to upgrade to node v20
2 participants