Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading score transformation #730

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

endigma
Copy link
Contributor

@endigma endigma commented Jul 5, 2023

The old version weights the scores such that the performance of non-Astro frameworks is understated. Change rebases this scale to 0 which does generate a bit of "dead space" but more accurately shows the relative difference between the scores.

@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for astro-www-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0ffc2bf
🔍 Latest deploy log https://app.netlify.com/sites/astro-www-2/deploys/64a57a48b041a80008543407
😎 Deploy Preview https://deploy-preview-730--astro-www-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@endigma endigma changed the title remove misleading score transformation Fix misleading score transformation Jul 5, 2023
@FredKSchott
Copy link
Member

LGTM! Thanks @endigma for opening a PR to fix this!

@FredKSchott FredKSchott merged commit cc76798 into withastro:main Jul 5, 2023
5 checks passed
tony-sull added a commit that referenced this pull request Jul 7, 2023
* move scores to the inside of the bars

* Update src/pages/_components/CoreWebVitalsGraphItem.astro

---------

Co-authored-by: Tony Sullivan <15836226+tony-sull@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants