Skip to content

Commit

Permalink
fix: add missing attribute to button (#9762)
Browse files Browse the repository at this point in the history
* fix: add missing attribute to button

* feedback
  • Loading branch information
ematipico committed Jan 22, 2024
1 parent 3ecb3ef commit 1fba856
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/lazy-fireants-clap.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"astro": patch
---

Adds `popovertarget" to the attribute that can be passed to the `button` element
2 changes: 2 additions & 0 deletions packages/astro/astro-jsx.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,7 @@ declare namespace astroHTML.JSX {
name?: string | undefined | null;
type?: 'submit' | 'reset' | 'button' | undefined | null;
value?: string | string[] | number | undefined | null;
popovertarget?: string | undefined | null;
}

interface CanvasHTMLAttributes extends HTMLAttributes {
Expand Down Expand Up @@ -811,6 +812,7 @@ declare namespace astroHTML.JSX {
type?: HTMLInputTypeAttribute | undefined | null;
value?: string | string[] | number | undefined | null;
width?: number | string | undefined | null;
popovertarget?: string | undefined | null;
}

interface KeygenHTMLAttributes extends HTMLAttributes {
Expand Down

0 comments on commit 1fba856

Please sign in to comment.