Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing attribute to button #9762

Merged
merged 2 commits into from Jan 22, 2024
Merged

Conversation

ematipico
Copy link
Member

Changes

Closes #9761
Closes PLT-1487

Testing

I manually tested the change in a local project

Docs

N/A

Copy link

changeset-bot bot commented Jan 22, 2024

🦋 Changeset detected

Latest commit: 43f8fb3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 22, 2024
@ematipico ematipico force-pushed the fix/missing-attribute-for-button branch from 469b4e5 to c8e603a Compare January 22, 2024 15:56
@ematipico ematipico merged commit 1fba856 into main Jan 22, 2024
13 checks passed
@ematipico ematipico deleted the fix/missing-attribute-for-button branch January 22, 2024 19:05
@astrobot-houston astrobot-houston mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

popovertarget attribute missing in ButtonHTMLAttributes and triggers ts error
3 participants