Fix/check content type (#1754)

* test: add test case * fix: add type guard insted of content.trim().length > 0 * test: fix test
withastro · Nov 9, 2021 · 7acf762 · 7acf762
1 parent f22a5c4
commit 7acf762
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/packages/astro/components/Markdown.astro b/packages/astro/components/Markdown.astro
@@ -20,7 +20,7 @@ const { privateRenderMarkdownDoNotUse: renderMarkdown } = (Astro as any);
 if (!content) {
   const { privateRenderSlotDoNotUse: renderSlot } = (Astro as any);
   content = await renderSlot('default');
-  if (content.trim().length > 0) {
+  if (content !== undefined && content !== null) {
     content = dedent(content);
   }
 }

diff --git a/packages/astro/test/astro-markdown.test.js b/packages/astro/test/astro-markdown.test.js
@@ -140,4 +140,10 @@ describe('Astro Markdown', () => {
     // test Markdown rendered correctly via content prop
     expect($('h1').text()).to.equal('Foo');
   });
+
+  it("doesn't occurs TypeError when no elements", async () => {
+    const html = await fixture.readFile('/no-elements/index.html');
+    // render html without error
+    expect(html).to.be.ok;
+  });
 });
diff --git a/packages/astro/test/fixtures/astro-markdown/src/pages/no-elements.astro b/packages/astro/test/fixtures/astro-markdown/src/pages/no-elements.astro
@@ -0,0 +1,5 @@
+---
+import { Markdown } from 'astro/components';
+---
+
+<Markdown></Markdown>