Fix/check content type #1754
Fix/check content type #1754
Conversation
|
| @@ -20,7 +20,7 @@ const { privateRenderMarkdownDoNotUse: renderMarkdown } = (Astro as any); | |||
| if (!content) { | |||
| const { privateRenderSlotDoNotUse: renderSlot } = (Astro as any); | |||
| content = await renderSlot('default'); | |||
| if (content.trim().length > 0) { | |||
| if (content !== undefined && content !== null) { | |||
There was a problem hiding this comment.
This makes sense to me. Obviously we’d need to test this, but I can see the logic in just assuming strings are correct, and handling non-strings like you’re doing here.
| it("doesn't occurs TypeError when no elements", async () => { | ||
| const html = await fixture.readFile('/no-elements/index.html'); | ||
| // render html without error | ||
| expect(!!html).to.equal(true); |
There was a problem hiding this comment.
| expect(!!html).to.equal(true); | |
| expect(html).to.be.ok; |
Same test; just a little easier to read.
* test: add test case * fix: add type guard insted of content.trim().length > 0 * test: fix test
Changes
resolve #1753
I added type guard to avoid TypeError when describing
Markdowncomponent with no children.Testing
I added the test case about this.
Docs
bug fix only