Remove support for Node 16 (#7780)

withastro · Aug 8, 2023 · d0679a6 · d0679a6
1 parent 4d160fa
commit d0679a6
Show file tree

Hide file tree

Showing 68 changed files with 129 additions and 95 deletions.
diff --git a/.changeset/afraid-dots-whisper.md b/.changeset/afraid-dots-whisper.md
@@ -0,0 +1,32 @@
+---
+'@astrojs/cloudflare': major
+'@astrojs/partytown': major
+'@astrojs/tailwind': major
+'@astrojs/netlify': major
+'@astrojs/sitemap': major
+'@astrojs/preact': major
+'@astrojs/svelte': major
+'@astrojs/vercel': major
+'@astrojs/react': major
+'@astrojs/solid-js': major
+'@astrojs/deno': major
+'@astrojs/node': major
+'@astrojs/lit': major
+'@astrojs/vue': major
+'create-astro': major
+'@astrojs/prism': major
+'@astrojs/rss': major
+'@astrojs/telemetry': major
+'@astrojs/webapi': major
+'astro': major
+'@astrojs/turbolinks': minor
+'@astrojs/alpinejs': minor
+'@astrojs/prefetch': minor
+'@astrojs/markdoc': minor
+'@astrojs/underscore-redirects': minor
+'@astrojs/image': minor
+'@astrojs/mdx': minor
+'@astrojs/internal-helpers': minor
+---
+
+Remove support for Node 16. The lowest supported version by Astro and all integrations is now v18.14.1. As a reminder, Node 16 will be deprecated on the 11th September 2023.
diff --git a/.github/ISSUE_TEMPLATE/---01-bug-report.yml b/.github/ISSUE_TEMPLATE/---01-bug-report.yml
@@ -10,7 +10,7 @@ body:
         Thank you for taking the time to file a bug report! Please fill out this form as completely as possible.
 
         ✅ I am using the **latest version of Astro** and all plugins.
-        ✅ I am using a version of Node that supports ESM (`v14.18.0+`, or `v16.12.0+`)
+        ✅ I am using a version of Node that Astro supports (`>=18.14.1`)
   - type: input
     id: astro-version
     attributes:

diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -34,7 +34,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: "pnpm"
 
       - name: Install dependencies

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -38,7 +38,7 @@ jobs:
     strategy:
       matrix:
         OS: [ubuntu-latest, windows-latest]
-        NODE_VERSION: [16]
+        NODE_VERSION: [18]
       fail-fast: true
     steps:
       # Disable crlf so all OS can share the same Turbo cache
@@ -85,7 +85,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: "pnpm"
 
       - name: Install dependencies
@@ -108,12 +108,12 @@ jobs:
     strategy:
       matrix:
         OS: [ubuntu-latest]
-        NODE_VERSION: [16, 18]
+        NODE_VERSION: [18, 20]
         include:
           - os: macos-latest
-            NODE_VERSION: 16
+            NODE_VERSION: 18
           - os: windows-latest
-            NODE_VERSION: 16
+            NODE_VERSION: 18
       fail-fast: false
     env:
       NODE_VERSION: ${{ matrix.NODE_VERSION }}
@@ -155,7 +155,7 @@ jobs:
     strategy:
       matrix:
         OS: [ubuntu-latest, windows-latest]
-        NODE_VERSION: [16]
+        NODE_VERSION: [18]
       fail-fast: false
     env:
       NODE_VERSION: ${{ matrix.NODE_VERSION }}
@@ -192,7 +192,7 @@ jobs:
     strategy:
       matrix:
         OS: [ubuntu-latest, windows-latest]
-        NODE_VERSION: [16]
+        NODE_VERSION: [18]
     env:
       NODE_VERSION: ${{ matrix.NODE_VERSION }}
     steps:

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -38,7 +38,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: "pnpm"
 
       - name: Install dependencies

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -30,7 +30,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: "pnpm"
 
       - name: Install dependencies

diff --git a/.github/workflows/scripts.yml b/.github/workflows/scripts.yml
@@ -37,7 +37,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: "pnpm"
 
       - name: Install dependencies

diff --git a/.github/workflows/snapshot-release.yml b/.github/workflows/snapshot-release.yml
@@ -58,7 +58,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           registry-url: "https://registry.npmjs.org"
           cache: "pnpm"
 

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-16.19.0
+18.14.1
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -10,7 +10,7 @@ We welcome contributions of any size and skill level. As an open source project,
 ### Prerequisites
 
 ```shell
-node: "^>=16.12.0"
+node: "^>=18.14.1"
 pnpm: "^8.6.2"
 # otherwise, your build will fail
 ```

diff --git a/benchmark/packages/timer/tsconfig.json b/benchmark/packages/timer/tsconfig.json
@@ -3,8 +3,8 @@
   "include": ["src"],
   "compilerOptions": {
     "allowJs": true,
-    "module": "ES2020",
+    "module": "ES2022",
     "outDir": "./dist",
-    "target": "ES2020"
+    "target": "ES2022"
   }
 }
diff --git a/package.json b/package.json
@@ -39,7 +39,7 @@
     "packages/*"
   ],
   "engines": {
-    "node": ">=16.12.0",
+    "node": ">=18.14.1",
     "pnpm": ">=8.6.2"
   },
   "packageManager": "pnpm@8.6.2",
@@ -82,7 +82,7 @@
     "@types/node": "^18.16.18",
     "@typescript-eslint/eslint-plugin": "6.0.0",
     "@typescript-eslint/parser": "6.0.0",
-    "esbuild": "^0.17.19",
+    "esbuild": "^0.18.16",
     "eslint": "^8.43.0",
     "eslint-config-prettier": "^8.8.0",
     "eslint-plugin-no-only-tests": "^2.6.0",
@@ -93,6 +93,6 @@
     "prettier-plugin-astro": "^0.10.0",
     "tiny-glob": "^0.2.9",
     "turbo": "^1.10.3",
-    "typescript": "~5.0.2"
+    "typescript": "~5.1.6"
   }
 }
diff --git a/packages/astro-prism/package.json b/packages/astro-prism/package.json
@@ -14,7 +14,7 @@
   "homepage": "https://docs.astro.build/en/reference/api-reference/#prism-",
   "main": "dist/index.js",
   "scripts": {
-    "build": "astro-scripts build \"src/**/*.ts\" && tsc",
+    "build": "astro-scripts build \"src/**/*.ts\" && tsc -p ./tsconfig.json",
     "build:ci": "astro-scripts build \"src/**/*.ts\"",
     "dev": "astro-scripts dev \"src/**/*.ts\""
   },
@@ -39,6 +39,6 @@
     "astro-scripts": "workspace:*"
   },
   "engines": {
-    "node": ">=16.12.0"
+    "node": ">=18.14.1"
   }
 }
diff --git a/packages/astro-prism/tsconfig.json b/packages/astro-prism/tsconfig.json
@@ -3,7 +3,7 @@
   "include": ["src"],
   "compilerOptions": {
     "allowJs": true,
-    "target": "ES2021",
+    "target": "ES2022",
     "module": "ES2022",
     "outDir": "./dist"
   }

diff --git a/packages/astro-rss/tsconfig.json b/packages/astro-rss/tsconfig.json
@@ -5,7 +5,7 @@
     "allowJs": true,
     "module": "ES2022",
     "outDir": "./dist",
-    "target": "ES2021",
+    "target": "ES2022",
     "strictNullChecks": true
   }
 }
diff --git a/packages/astro/astro.js b/packages/astro/astro.js
@@ -13,8 +13,8 @@ const CI_INSTRUCTIONS = {
 };
 
 // Hardcode supported Node.js version so we don't have to read differently in CJS & ESM.
-const engines = '>=16.12.0';
-const skipSemverCheckIfAbove = 16;
+const engines = '>=18.14.1';
+const skipSemverCheckIfAbove = 19;
 
 /** `astro *` */
 async function main() {

diff --git a/packages/astro/package.json b/packages/astro/package.json
@@ -141,8 +141,8 @@
     "devalue": "^4.3.2",
     "diff": "^5.1.0",
     "es-module-lexer": "^1.3.0",
-    "esbuild": "^0.17.19",
-    "estree-walker": "3.0.0",
+    "esbuild": "^0.18.16",
+    "estree-walker": "^3.0.3",
     "execa": "^6.1.0",
     "fast-glob": "^3.2.12",
     "github-slugger": "^2.0.0",
@@ -224,7 +224,7 @@
     }
   },
   "engines": {
-    "node": ">=16.12.0",
+    "node": ">=18.14.1",
     "npm": ">=6.14.0"
   }
 }
diff --git a/packages/astro/src/core/build/plugins/plugin-analyzer.ts b/packages/astro/src/core/build/plugins/plugin-analyzer.ts
@@ -1,3 +1,4 @@
+import type { Node as ESTreeNode } from 'estree-walker';
 import type { ModuleInfo, PluginContext } from 'rollup';
 import type { Plugin as VitePlugin } from 'vite';
 import type { PluginMetadata as AstroPluginMetadata } from '../../../vite-plugin-astro/types';
@@ -36,7 +37,7 @@ async function doesParentImportChild(
 
 	const imports: Array<ImportDeclaration> = [];
 	const exports: Array<ExportNamedDeclaration | ExportDefaultDeclaration> = [];
-	walk(parentInfo.ast, {
+	walk(parentInfo.ast as ESTreeNode, {
 		enter(node) {
 			if (node.type === 'ImportDeclaration') {
 				imports.push(node as ImportDeclaration);

diff --git a/packages/astro/src/vite-plugin-astro-postprocess/index.ts b/packages/astro/src/vite-plugin-astro-postprocess/index.ts
@@ -1,4 +1,5 @@
 import { parse } from 'acorn';
+import type { Node as ESTreeNode } from 'estree-walker';
 import { walk } from 'estree-walker';
 import MagicString from 'magic-string';
 import type { Plugin } from 'vite';
@@ -28,7 +29,7 @@ export default function astro(): Plugin {
 				sourceType: 'module',
 			});
 
-			walk(ast, {
+			walk(ast as ESTreeNode, {
 				enter(node: any) {
 					// Transform `Astro.glob("./pages/*.astro")` to `Astro.glob(import.meta.glob("./pages/*.astro"), () => "./pages/*.astro")`
 					// Also handle for `Astro2.glob()`

diff --git a/packages/astro/tsconfig.json b/packages/astro/tsconfig.json
@@ -6,7 +6,7 @@
     "declarationDir": "./dist",
     "module": "ES2022",
     "outDir": "./dist",
-    "target": "ES2021",
+    "target": "ES2022",
     "jsx": "preserve",
     "types": ["@types/dom-view-transitions", "network-information-types"]
   }

diff --git a/packages/create-astro/package.json b/packages/create-astro/package.json
@@ -47,6 +47,6 @@
     "strip-json-comments": "^5.0.0"
   },
   "engines": {
-    "node": ">=16.12.0"
+    "node": ">=18.14.1"
   }
 }
diff --git a/packages/create-astro/tsconfig.json b/packages/create-astro/tsconfig.json
@@ -5,7 +5,7 @@
     "allowJs": true,
     "emitDeclarationOnly": false,
     "noEmit": true,
-    "target": "ES2021",
+    "target": "ES2022",
     "module": "ES2022",
     "outDir": "./dist",
     "declarationDir": "./dist/types"

diff --git a/packages/integrations/alpinejs/tsconfig.json b/packages/integrations/alpinejs/tsconfig.json
@@ -5,6 +5,6 @@
     "allowJs": true,
     "module": "ES2022",
     "outDir": "./dist",
-    "target": "ES2021"
+    "target": "ES2022"
   }
 }
diff --git a/packages/integrations/cloudflare/package.json b/packages/integrations/cloudflare/package.json
@@ -41,7 +41,7 @@
   "dependencies": {
     "@astrojs/underscore-redirects": "^0.2.0",
     "@cloudflare/workers-types": "^4.20230518.0",
-    "esbuild": "^0.17.19",
+    "esbuild": "^0.18.16",
     "tiny-glob": "^0.2.9"
   },
   "peerDependencies": {

diff --git a/packages/integrations/cloudflare/tsconfig.json b/packages/integrations/cloudflare/tsconfig.json
@@ -5,6 +5,6 @@
     "allowJs": true,
     "module": "ES2022",
     "outDir": "./dist",
-    "target": "ES2021"
+    "target": "ES2022"
   }
 }
diff --git a/packages/integrations/deno/tsconfig.json b/packages/integrations/deno/tsconfig.json
@@ -5,6 +5,8 @@
     "allowJs": true,
     "module": "ES2022",
     "outDir": "./dist",
-    "target": "ES2021"
+    "target": "ES2022",
+    // TODO: Due to the shim for Deno imports in `server.ts`, we can't use moduleResolution: 'bundler' or the types get very weird.
+    "moduleResolution": "Node"
   }
 }
diff --git a/packages/integrations/image/tsconfig.json b/packages/integrations/image/tsconfig.json
@@ -5,7 +5,7 @@
     "allowJs": true,
     "module": "ES2022",
     "outDir": "./dist",
-    "target": "ES2021",
+    "target": "ES2022",
     "typeRoots": ["node_modules/@types", "node_modules/@netlify"]
   }
 }
diff --git a/packages/integrations/lit/tsconfig.json b/packages/integrations/lit/tsconfig.json
@@ -5,6 +5,6 @@
     "allowJs": true,
     "module": "ES2022",
     "outDir": "./dist",
-    "target": "ES2021"
+    "target": "ES2022"
   }
 }
diff --git a/packages/integrations/markdoc/package.json b/packages/integrations/markdoc/package.json
@@ -66,7 +66,7 @@
     "@astrojs/internal-helpers": "^0.1.2",
     "@astrojs/prism": "^2.1.2",
     "@markdoc/markdoc": "^0.3.0",
-    "esbuild": "^0.17.19",
+    "esbuild": "^0.18.16",
     "github-slugger": "^2.0.0",
     "gray-matter": "^4.0.3",
     "htmlparser2": "^9.0.0",
@@ -93,6 +93,6 @@
     "vite": "^4.4.6"
   },
   "engines": {
-    "node": ">=16.12.0"
+    "node": ">=18.14.1"
   }
 }