Remove support for Node 16 #7780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 56ebee2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: svelte
github-actions
bot
added
pkg: lit
|
Should we address this? import { File, FormData, Headers, Request, Response, fetch } from 'undici' // Remove when Node 16 is dropped for Node 18.It would help deno and bun if they could use their own implementation and slightly reduce how long users have to wait when installing astro. |
Intentionally skipped in this PR, I plan to tackle the |
matthewp
approved these changes
Jul 24, 2023
ematipico
approved these changes
Jul 24, 2023
bluwy
reviewed
Jul 24, 2023
Princesseuh
force-pushed
the
feat/deprecate-16
branch
from
5aec250
to
d6505c3
Compare
ematipico
pushed a commit
that referenced
this pull request
Jul 25, 2023
ematipico
pushed a commit
that referenced
this pull request
Jul 26, 2023
ematipico
pushed a commit
that referenced
this pull request
Jul 26, 2023
ematipico
added a commit
that referenced
this pull request
Jul 26, 2023
ematipico
pushed a commit
that referenced
this pull request
Jul 27, 2023
ematipico
added a commit
that referenced
this pull request
Jul 27, 2023
ematipico
pushed a commit
that referenced
this pull request
Jul 31, 2023
ematipico
added a commit
that referenced
this pull request
Jul 31, 2023
ematipico
pushed a commit
that referenced
this pull request
Aug 1, 2023
ematipico
added a commit
that referenced
this pull request
Aug 1, 2023
ematipico
pushed a commit
that referenced
this pull request
Aug 1, 2023
ematipico
added a commit
that referenced
this pull request
Aug 1, 2023
ematipico
pushed a commit
that referenced
this pull request
Aug 3, 2023
ematipico
added a commit
that referenced
this pull request
Aug 3, 2023
ematipico
pushed a commit
that referenced
this pull request
Aug 8, 2023
ematipico
added a commit
that referenced
this pull request
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Move our lowest supported version to v18.14.1. That specific version of Node 18 was chosen as previous versions had issues in their fetch implementation. While those issues don't necessarily affect the majority of users, it's safer for us to recommend a version we know work in every situation.
Moving up a Node version also allow us to uses TypeScript's newest features, as such this also migrates us to
moduleResolution: 'bundler'.Changes to
@astrojs/webapiwere skipped in this PR, I'll tackle those separately to make sure I don't remove needed polyfills and stuff.Testing
Tests should all pass!
Docs
Will do a PR to docs to update the installation page