Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let middleware handle the original request URL #11211

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Let middleware handle the original request URL #11211

merged 2 commits into from
Jun 10, 2024

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Jun 7, 2024

Changes

  • This undoes the logic of 6035bb3
    • Tried to do a revert but too much has changed since then.
  • With SSR you should be able to handle any URL provided.
  • In SSG it's not possible to receive such a path anyways, so its not up to Astro to fix it for you in dev mode.
  • Fixes Handle multiple slashes in url #10989

Testing

  • Test added
  • Old test removed

Docs

N/A, bug fix

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 82a2677

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 7, 2024
@ematipico ematipico merged commit 97724da into main Jun 10, 2024
13 checks passed
@ematipico ematipico deleted the trip-slash branch June 10, 2024 09:58
@astrobot-houston astrobot-houston mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle multiple slashes in url
2 participants
@matthewp @ematipico