Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom svelte compiler options in @astrojs/svelte #3181

Merged
merged 6 commits into from
Apr 22, 2022

Conversation

tony-sull
Copy link
Contributor

Changes

Similar to #3143, this updates the Svelte integration to allow users to override most of the Svelte config.

emitCss, dev, and hydratable are always managed by the Astro integration, everything else can be overridden

Testing

Updated the svelte-component test to verify that overriding the extensions option works as expected in the Svelte compiler

Docs

README updated with documentation on providing custom Svelte compiler option.

@changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2022

🦋 Changeset detected

Latest commit: 730418d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: svelte Related to Svelte (scope) pkg: integration Related to any renderer integration (scope) test labels Apr 22, 2022
@tony-sull tony-sull self-assigned this Apr 22, 2022
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Svexcellent updates, README, and tests! Just want to remove those temporary scripts, but otherwise LGIP

packages/astro/package.json Outdated Show resolved Hide resolved
@tony-sull tony-sull merged commit ce9a61e into main Apr 22, 2022
@tony-sull tony-sull deleted the feat/svelte-options branch April 22, 2022 17:59
@github-actions github-actions bot mentioned this pull request Apr 22, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
…3181)

* updating svelte integration to allow custom user config

* test: adding a test to verify that svelte options are piped through the integration

* updating the README with docs on overridding svelte options

* chore: adding changeset

* fix: copy/paste bug in test validation

* removing temporary debug scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: svelte Related to Svelte (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants