Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Astro attributes to svg elements #3205

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Add Astro attributes to svg elements #3205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e90da3
Add Astro attributes to svg elements
Princesseuh Apr 26, 2022
dbb15f6
Add changeset
Princesseuh Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/metal-doors-rhyme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Added Astro attributes to SVG elements in JSX definition
5 changes: 4 additions & 1 deletion packages/astro/astro-jsx.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,10 @@ declare namespace astroHTML.JSX {
// - "number | string"
// - "string"
// - union of string literals
interface SVGAttributes<T extends EventTarget> extends AriaAttributes, DOMAttributes<T> {
interface SVGAttributes<T extends EventTarget>
extends AriaAttributes,
DOMAttributes<T>,
AstroBuiltinAttributes {
// Attributes which also defined in HTMLAttributes
className?: string | undefined | null;
class?: string | undefined | null;
Expand Down