Ensure hydration scripts inside of slots render ASAP

[matthewp]

Changes

• Fixes another race condition in rendering hydration script that's caused when both a slot and a child component contain hydrated scripts.
• Since slots render to strings we need not render those scripts inside the slot, instead we inform renderPage() that the scripts are needed so that it can ensure they are added before any islands.

Testing

• Test added for this race condition.

Docs

N/A, bug fix.

[changeset-bot]

🦋 Changeset detected

Latest commit: 733ed00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
astro	Patch
@e2e/astro-component	Patch
@e2e/error-react-spectrum	Patch
@e2e/error-sass	Patch
@e2e/errors	Patch
@e2e/lit-component	Patch
@e2e/preact-component	Patch
@e2e/react-component	Patch
@e2e/solid-component	Patch
@e2e/solid-recurse	Patch
@e2e/svelte-component	Patch
@e2e/e2e-tailwindcss	Patch
@e2e/ts-resolution	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[natemoo-re]

Great fix, thanks!

[matthewp]

This PR had to be reverted to causing a regression. I have another, much safer, idea of how to fix that. Branch started here: https://github.com/withastro/astro/tree/slot-bug-1

[elevatebart]

Hello @matthewp,

Since this fix had to be reverted, could we re-open the other ticket until it is fixed again.
I only want this so that I can know when I can remove the hack I added (<Empty client:idle/>)

Thank you in advance,
Bart

[matthewp]

Yes, thanks for the reminder.

[DevHusariaSolutions]

Hello guys, how's going? I've just ported app to vite-plugin-ssr for now, but I still hope You gonna make it work to let my SolidJS app works as You describe in docs :)
I've seen You merged new fix day before I published #4343 . Since preact is quite simple framework - I'm not so confident about SolidJS usage before tests for such frameworks. I know You have a lot of work, but I think that tests for framework listed in PRs related to some bug should be handled.
For now testing newer version of Astro bumped me in another issue... (some library instead getting ref of element, it gets:
{ t: "<div>...</div>" }
so probably hydration messes around here :/