Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peer dep with Tailwindcss #4543

Merged

Conversation

aFuzzyBear
Copy link
Contributor

workerB

Changes

updated package.json with tailwindcss as a peer dependency of the integration itself.

Unsure if changeset is needed

Testing

N/A

Docs

N/A

@aFuzzyBear aFuzzyBear linked an issue Aug 29, 2022 that may be closed by this pull request
1 task
@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2022

🦋 Changeset detected

Latest commit: 141d720

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@astrojs/tailwind Major
@e2e/e2e-tailwindcss Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 29, 2022
@aFuzzyBear aFuzzyBear mentioned this pull request Aug 29, 2022
29 tasks
@FredKSchott
Copy link
Member

FredKSchott commented Aug 29, 2022

Is this a breaking change? I think so. It might not be since tailwind is still a dependency, but in that case this change isn't actually doing anything. It makes more sense to remove tailwind as a "dependency", only list it as a "peerDependency", and call this a major release of the integration.

Is this going to unexpectedly break users? It won't as long as we correctly changeset it as a major bump, with good information in the changelog. But it's definitely a big change and we should talk about timing before merging this PR.

@aFuzzyBear
Copy link
Contributor Author

Thanks @FredKSchott, I made the amendment, in respects to the second question I would defer to your wisdom on this one.

Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@matthewp
Copy link
Contributor

What's the status of this one @aFuzzyBear, is it ready to go?

@aFuzzyBear
Copy link
Contributor Author

What's the status of this one @aFuzzyBear, is it ready to go?

pretty much yes I believe, @bluwy did sign off on it, wasn't sure if there was anything else needed to be done, I'm hesitatent to merge this myself, unless given the okay,

@aFuzzyBear aFuzzyBear merged commit 664ebf4 into main Sep 14, 2022
@aFuzzyBear aFuzzyBear deleted the 4542-tailwind-should-be-a-peer-dep-of-the-tailwind-integration branch September 14, 2022 19:17
@astrobot-houston astrobot-houston mentioned this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tailwind should be a peer dep of the tailwind integration
4 participants