feat(astro/component): adds an inline tag attribute for inline code #5973
Conversation
🦋 Changeset detectedLatest commit: 56fa652 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Lofty-Brambles
changed the title
github-actions
bot
added
the
pkg: astro
|
Looks like your branch has some conflicts. I would fix those and rebase with |
|
That should do it? The ubuntu-latest build is failing due to a type mismatch between |
|
This issue seems to arise from Which is resolving to string | IShikiTheme instead of Theme | IShikiTheme. Not sure as to how to fix this though- particularly why BUNDLED_THEMES is typed like [Theme, ...Theme[]]
|
|
Why would that be causing build issues? Your change doesn't touch that file? Oh, is it just because you updated the Shiki version? |
|
Yep, the bump seems to be the reason |
|
Closing as this is stale. The changes look good! Please resubmit when you get the time. |
Changes
This adds an inline attribute to render code in the
<Code />component as inline code without the pre tag.This PR is related to the issue: #5912
Testing
No tests were present for the
<Code />component.Docs
Is this, along with the other attributes necessary to be documented? The current docs on it is pretty barebones. I'm willing to add a PR, if necessary.
/cc @withastro/maintainers-docs for feedback!