Refactor content collection transforms #6817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1d16001 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
github-actions
bot
removed
the
pkg: example
bholmesdev
commented
Apr 11, 2023
| @@ -104,6 +105,11 @@ interface AstroPluginJSXOptions { | |||
| logging: LogOptions; | |||
| } | |||
|
|
|||
| // Format inspired by https://github.com/vitejs/vite/blob/main/packages/vite/src/node/constants.ts#L54 | |||
| const SPECIAL_QUERY_REGEX = new RegExp( | |||
There was a problem hiding this comment.
I discovered our JSX runtime will try to process files with special flags like ?raw and ?astroContent. This regex should prevent that
github-actions
bot
added
the
pkg: integration
bholmesdev
commented
Apr 11, 2023
|
|
||
| function isPropagatedAsset(viteId: string, contentEntryExts: string[]): boolean { |
There was a problem hiding this comment.
contentEntryExts check removed. Speeds up check and unlocks for future file extensions
bluwy
reviewed
Apr 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
loadstep for content collection imports and assets to thetransformstep. This reduces complexity and unblocks support for content extensions with existing transforms from Vite core, like.json(reason for unblock here).vite.build.sourcemapoption to content collections and the MDX plugin. When present, generate source maps. Avoid generating otherwise to prevent perf bottlenecks.Testing
Docs