add warn message when using unsupported file types in pages/ #6851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 41263d3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
This seems like a nice addition, but it does make setups that "intentionally put images beside the page file so it can be imported relatively" show the warning. I don't think it's a big deal since we're introducing the Curious to hear what others think too. |
matthewp
approved these changes
May 17, 2023
ematipico
approved these changes
May 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Motivation
Occasionally, I messed up the file extensions and wondered why the page is not found. Especially since Vite just shows "updated file xyz", I think this warning message might be useful to the user
Testing
Tested with the projects from
examples/, unit testing logging does not really make senseDocs
Docs are not needed since this feature serves as a way to alert the user that something is wrong. Docs are already clear on which file extensions are allowed