Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add warn message when using unsupported file types in pages/ #6851

Merged
merged 6 commits into from
May 17, 2023
Merged

add warn message when using unsupported file types in pages/ #6851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
859aeea
add warn message when using unsupported file types in pages/
timozander Apr 15, 2023
d05d6cf
Merge branch 'main' into warn-invalid-pages-extensions
natemoo-re Apr 20, 2023
42cecb0
Merge branch 'main' into warn-invalid-pages-extensions
timozander Apr 22, 2023
6690d9d
Merge branch 'main' into warn-invalid-pages-extensions
timozander Apr 25, 2023
f63554a
Merge branch 'main' into warn-invalid-pages-extensions
timozander May 17, 2023
41263d3
Merge branch 'main' into warn-invalid-pages-extensions
Princesseuh May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hip-bottles-hide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Added warning message when using unsupported file extensions in pages/
7 changes: 7 additions & 0 deletions packages/astro/src/core/routing/manifest/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,8 @@ export function createRouteManifest(
const localFs = fsMod ?? nodeFs;
const isPrenderDefault = isHybridOutput(settings.config);

const foundInvalidFileExtensions: Set<string> = new Set();

function walk(
fs: typeof nodeFs,
dir: string,
Expand All @@ -252,6 +254,11 @@ export function createRouteManifest(
}
// filter out "foo.astro_tmp" files, etc
if (!isDir && !validPageExtensions.has(ext) && !validEndpointExtensions.has(ext)) {
if (!foundInvalidFileExtensions.has(ext)) {
foundInvalidFileExtensions.add(ext);
warn(logging, 'astro', `Invalid file extension for Pages: ${ext}`);
}

return;
}
const segment = isDir ? basename : name;
Expand Down