Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add astro-static-slot to the list of inert tags in astro css #7189

Merged
merged 3 commits into from May 24, 2023
Merged

fix: add astro-static-slot to the list of inert tags in astro css #7189

merged 3 commits into from May 24, 2023

Conversation

elevatebart
Copy link
Contributor

Changes

In a recent version of Astro we introduced the <astro-static-slot> element. Prior to this only <astro-slot> and <astro-island>.

When we have this kind of code, we expect the slot to not have an effect ad the div and the image to be on the same line.

<div style="display: flex;">
  <astro-static-slot>
    <img src="test.jpg" />
    <div>Button Content</div>
  </astro-static-slot>
</div>

Testing

It's a simple bug fix, could be tested if browser rendering had apis.

Docs

Bug fix

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2023

🦋 Changeset detected

Latest commit: 94c963f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 23, 2023
@bluwy bluwy merged commit 2bda7fb into withastro:main May 24, 2023
5 checks passed
@bluwy
Copy link
Member

bluwy commented May 24, 2023

Thanks!

@astrobot-houston astrobot-houston mentioned this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants