Node built-in modules support for Deno adapter #7288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b46ee61 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
lilnasy
force-pushed
the
node-compat-deno
branch
2 times, most recently
from
6bfe244
to
044f9d6
Compare
lilnasy
force-pushed
the
node-compat-deno
branch
3 times, most recently
from
7ee3d9c
to
b46ee61
Compare
natemoo-re
approved these changes
Jun 8, 2023
Yeah, that sounds good. |
|
I would have liked to include an npm library that uses a supported node built-in module, but couldn't find one that's appropriate for CI. |
1 task
matthewp
approved these changes
Jun 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It seems to be a use case that's receiving more and more interest. Deno can leverage built-in node modules, but it's blocked by an overly restrictive configuration set by the adapter.
Testing
nodecompat.astro
Docs
Not a user facing change, though a note somewhere could be useful.