fix(astro): strongly type Astro.self

[43081j]

Changes

Basically trying to strongly type Astro.self so we can get completions in the language tools.

This is the safest non-breaking way I could think of doing it, since AstroComponentFactory should work as it did before if you don't specify any type parameters.

I'm not entirely sure how AstroComponentFactory ends up working in TSX (in the type system) since it doesn't look like the shape of a JSX element. so this may also be the completely wrong solution. either way, if someone could explain that gap in my knowledge, that'd be super helpful

This should fix withastro/language-tools#612

Testing

Couldn't find any existing tests for the types package. If there are some, i'm happy to add to them.

Docs

N/A since the behaviour should remain the same

[changeset-bot]

🦋 Changeset detected

Latest commit: eb216b1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ematipico]

cc @Princesseuh

[Princesseuh]

So, in that type there's a bit of a confusion where sure, AstroComponentFactory is the proper type in Astro itself, but it's not the proper type in the editor tooling (for multiple reasons).

Ultimately, the type of Astro.self only matters for editor tooling, because it's 100% handled in the compiler anyway. So what I would suggest is that instead, is to add a type param here:

astro/packages/astro/src/@types/astro.ts

Line 141 in 682d02b

export interface AstroGlobal<Props extends Record<string, any> = Record<string, any>>

that types self. Then in the compiler, in the TSX we'll pass a typeof of the default function to the type param.

[43081j]

have updated this to take a Self which defaults to the component factory it used before to keep it backwards compatible.

the associated compiler change is here: withastro/compiler#843