feat: add noop service and make integrations that needs it use it #7903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 90ffd3d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
bluwy
reviewed
Aug 1, 2023
Princesseuh
force-pushed
the
feat/noop-image-service
branch
from
4a3a5f4
to
635b702
Compare
Princesseuh
force-pushed
the
feat/noop-image-service
branch
from
635b702
to
bc91d59
Compare
github-actions
bot
removed
the
pkg: integration
natemoo-re
approved these changes
Aug 2, 2023
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
For Cloudflare, Deno, Vercel Edge and Netlify Edge, who don't support Squoosh or Sharp, we instead provide an image service that does nothing
Testing
Tested manually
Docs
This shouldn't affect user behaviour from
experimental.assets, as previously well, it didn't work. Happy to document this though if @withastro/maintainers-docs feels it's necessary!