Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate slash handling #7935

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Fix duplicate slash handling #7935

merged 5 commits into from
Aug 3, 2023

Conversation

natemoo-re
Copy link
Member

Changes

Testing

Tests added

Docs

N/A, bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2023

🦋 Changeset detected

Latest commit: 24f7a81

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 3, 2023
@natemoo-re natemoo-re merged commit 6035bb3 into main Aug 3, 2023
13 checks passed
@natemoo-re natemoo-re deleted the fix/duplicate-slashes branch August 3, 2023 18:13
@astrobot-houston astrobot-houston mentioned this pull request Aug 3, 2023
ematipico pushed a commit that referenced this pull request Aug 4, 2023
* fix(#7806): collapse duplicate slashes

* refactor: handle request.url with duplicate slashes

* chore: improve duplicate slash test

* fix: only collapse duplicate slashes once

* chore: appease TS
@matthewp matthewp mentioned this pull request May 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Three of more slashes as path returns 400 "Bad Request" instead of 404 page
2 participants